-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI request when namespace is in argument and part of the path #12720
Conversation
… argument and part of the path fixes #12675
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments that would improve the readability and error handling. It looks good at a high level but we should add some tests to validate that the bug no longer exists. Some test scenarios might provide a little extra context for me to analyze the logic a little further as well.
Yes, I am creating some tests, however, the tests are going to be in the enterprise side, as namespaces are required to fully examine the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…corp#12720) * CLI makes request to incorrect URL when namespace is both provided as argument and part of the path fixes hashicorp#12675 * adding change log * removing a switch and addressing a possibility of out of bound index
CLI makes request to incorrect URL when namespace is both provided as argument and part of the path
fixes #12675